Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: modify the error message of insert time value (#20847) #20898

Closed
wants to merge 6 commits into from
Closed

executor: modify the error message of insert time value (#20847) #20898

wants to merge 6 commits into from

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20847 to release-4.0

What problem does this PR solve?

Issue Number: close #20207

Problem Summary:

What is changed and how it works?

What's Changed:

Change error code and error info when insert time value.

Check List

Tests

  • Unit test

Release note

  • Change error code and error info when insert time value.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 6, 2020
Merged
@ti-srebot ti-srebot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. rewarded sig/execution SIG execution type/4.0-cherry-pick labels Nov 6, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 6, 2020
SunRunAway
SunRunAway reviewed Nov 17, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
@lzmhhh123
Copy link
Contributor

/rebuild

ichn-hu
ichn-hu previously approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 17, 2020
@ichn-hu
Copy link
Contributor

ichn-hu commented Nov 17, 2020

/run-all-tests

@lzmhhh123
Copy link
Contributor

/run-all-tests

@lzmhhh123
Copy link
Contributor

/rebuild

@SunRunAway SunRunAway modified the milestones: v4.0.9, v4.0.10 Nov 30, 2020
@ti-srebot
Copy link
Contributor Author

@ti-srebot, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor Author

@ti-srebot, please update your pull request.

@ti-srebot
Copy link
Contributor Author

@ti-srebot PR closed due to no update for a long time. Feel free to reopen it anytime.

@ti-srebot ti-srebot closed this Dec 30, 2020
@ichn-hu ichn-hu mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@ichn-hu ichn-hu ichn-hu left review comments

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees

@lzmhhh123 lzmhhh123

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @lzmhhh123 @ichn-hu @SunRunAway @zz-jason @ou-bing